Build 24 bugs

[mauronen]

Hi Johannes.
These time i've wanted to split bugs not for severity, but for GC2 sections:

Generation > General section

it seems that, using Width and Height slider, maximum limit is respectively 10000km and 3000mt, but using input text, fields values are unlimitedGeneration > Filter section



Smoothing filter presets seems to be wrong or corrupted
When you select a Smoothing filter preset, then delete Smoothing filter and go to Selector panel and then try to change Height max (without check Enable Height) appears this:An attempted read or write to/from an address to which that process isn't allowed
4214 in Module E:\PB\GeoControlV2\Libs\Events.pb
Should GeoControl try to continue?

When you use multiple Erosion filter (try to insert ALL Erosion filters, though it could be meaningless) occours 2 related kind of anomalies:1) Erosion selections doesn't delete

2) When you want to delete some erosion filter, after deletion of first filter (without messages), trying to delete second, third and so on erosion filters, GC2 show this panel:

This selection is used and can not be removed!
though filters are deleted

Canyons Filter:Settings panel; Edge Sharpness label is doubled; i've read help file, but it seems to have same behaviour, even though some presets have,each one, different values. This bug was already present in the past.
Four Terraces: Settings panel; disable settings panel or it shows that all sliders hasn't label (min-max) value. This bug was already present in the past.
Filter: Invert: Settings panel; disable settings panel or it shows that all sliders hasn't label (min-max) value. This bug was already present in the past.Postwork section



When i delete a River and lake postwork filter, in Selections list remains <terrain size>-Spring (<number>)_bank selection
When i delete a Vector postwork filter, in Selections list remains <terrain size>-Vector tool (<number>)_border selection
When i create a terrain that has some postwork filters, and i try to load terrain setting file (overriding previous terrain) previous postwork group and related postwork filters remain
River and lake postwork filter: the Area slider left unchanged when you change Terrain Size dimension in Generation > General section
Render section



When try to set Distance slider and Point at slider to minimum GC2 freezes
When set terrain height to very huge value (15000mt and over) and try to render with Full quality radio enabled, start to appear various errors when set different view angles:1) view angle of 135°,225°,315° appears this:
An attempted read or write to/from an address to which that process isn't allowed
1148 in Module E:\PB\GeoControlV2\Libs\View.pb
Should GeoControl try to continue?
2) view angle of 45°appears this:
An attempted read or write to/from an address to which that process isn't allowed
1155 in Module E:\PB\GeoControlV2\Libs\View.pb
Should GeoControl try to continue?
these bugs seems to be correlated to Width/Height ratio, but i cannot reproduce errors with the exactly edge ratio.

[cajomi]

Thanks again for your great help to make GC2 a rock stable application!!


Generator - why is it a bug, if can get higher with the numerical input, others call that a feature, but I fixed that. You will find now the values jumping, when you change the unit, please do not post that as bug. It correlates the sliders to the inputs, and a change of the unit changes the limits.

Smoothing filter
Was a bug, the presets were the filter presets for valley smoothing, is fixed.

Deleting filters:
Is fixed. If now a selection uses the filter, the selection is resetted


Canyon filter:
No bug, exact as it should be. Set ground height to 1000, push generate, set second edge sharpness slider now to zero, and push generate again, do a equal operation with the first two sliders.

Invert filter / Four terraces:
Hm, I would call that a feature request, which I did not follow, so far. Please do not post such things as bug. That are not a fail functions.

Postworksection:
Bank and border selections are now deleted also.
After loading a preset, you must push generate to see the changings in the pw section. Will change that, but may be not next build.
River and lake area: Why should there change something, if you change the terrain size? No bug, it works as it is supposed.

Render section:
The render bug would take much time, a general improvement is necessary to fix that. That bug is wellknown and I always said, "avoid those settings" and did not wrote "will be fixed" or "is fixed".

[mauronen]

Hi Johannes.

Generator - why is it a bug, if can get higher with the numerical input, others call that a feature, but I fixed that. You will find now the values jumping, when you change the unit, please do not post that as bug. It correlates the sliders to the inputs, and a change of the unit changes the limits.
I supposed that Width and Height sliders follow behaviour of other controls, in particular those that have limits declared. I agree that higher values could be a feature, but i don't know how GC2 could react with very huge values (i've reached 99999999999 and so on on both input text), so i though that fix limits could preserve GC2 from crashes; but if you think that they don't affect GC2 integrity, let them unlimited


Canyon filter:
No bug, exact as it should be. Set ground height to 1000, push generate, set second edge sharpness slider now to zero, and push generate again, do a equal operation with the first two sliders.
This is excerpt from GC2 English help:

Canyons

The "Canyon" filter strtches the terrain. The lower parts are lowered, the hihger parts are raised, so that canyons are formed.


Top Height:
All above this height is raised. That means, the lower this value, the stronger the canyon effect.
Edge Sharpness:
This regulates, how fast the filter starts, which leads to more or less sharp edges.

Ground Height:
All altitudes, that are lower then the "Ground Height" are lowered. So, the higher the value of "Ground Height", the more the terrain is lowered.

Edge Sharpness:
Regulates, how fast the filter starts, which leeds to more or less sharp edges.



I agree with your explanation, but reading that filter i believed that it was an error, due almost equal explanation of these two parameters.

Invert filter / Four terraces:
Hm, I would call that a feature request, which I did not follow, so far. Please do not post such things as bug. That are not a fail functions.
Following your previous reply to this post: http://www.cajomi.de/Forum/showthread.php?t=496&page=3 that you said:
9. Invert simply inverts, so no labeld sliders i though that, as similar as other filter settings that have Terraces label disabled, could be possible disable Settings label for those filters that don't use.


...River and lake area: Why should there change something, if you change the terrain size? No bug, it works as it is supposed.
Sorry, my mistake. I see now that Area slider reaches 4096 maximum value although Terrain size value is different

Render section:
The render bug would take much time, a general improvement is necessary to fix that. That bug is wellknown and I always said, "avoid those settings" and did not wrote "will be fixed" or "is fixed".
Ok Johannes.
In the future i will not write no more about Render section bugs.

[cajomi]

Generator:
I wrote "but I fixed that." That fixing will cause a jumping slider if you change the unit, also the values will change. If you do not like that, I only meant, that you should not post that as a bug, because it is no bug but to feature requests.


Invert:
This is no bug, this is a feature request. I want to try to make the pre-release mostly bug free, (except the render engine), but not mostly "feature request free".

And of cause I will need again bug reports to the render engine, after it is improved.

[mauronen]

Johannes: i hope that you always understand the spirit of my approach about GC2 testing, and that bring me to reply to some your posts.
I ever though that a forum or a chat don't allow to completely trasmit right messages to other people, because different language (my english isn't so strong) and because is impossible to share things like gestures or emotions when peoples talks each other.
If i reported in this section GC2 behaviours that "seemed to me bugs", not necessarily "are bugs".
As i said to you in previous post, about Widht and Height sliders, i thought that, without widht and height limits, GC2 could crash.
Again, about Invert, this isn't a feature request, for me, but only a way to prevent tha GC2 crashes. Since i've remembered that, in the past, for other filters that don't use Terraces section, you had disabled it, i thought that could be possible to disable Settings section to those filters that don't use it, without think if it would be a bug or a feature request. If you think that it's a feature request, is O.K.; i don't discuss it, not because i agree or not agree about your opinion, but because you think that this isn't a bug but a feature request.
I didn't never wanted to discuss to you about GC2 philosophy, but only to help to improve it. As i said to you: "you're master in your home".
If i wanted ask to you feature requests, as i've done in the past, i will have posted them in "Feature request" section.
So, i understand when you say that "this thing or this other thing isn't a bug but a feature request", but i cannot previously foresee it.
Therefore, be patient.

[cajomi]

I agree, and of course a discussion about what is bug and what not would only be wasted time.

And I am really thankful for your bug reports.

[mauronen]

This bug has been really difficult to find:

Switch to Generation > Isolines section
Create an isoline with height 2 enabled, first value greater than second value (even if it think that values are uninfluenced)
Pick Select isoline tool
Select isoline (it becomes dotted)
Select Draw isoline tool
Change state of at least three of four isoline controls (height 1 from Manual to Auto, move slider, height 2 from Manual to Auto, move slider)appear this:
An attempted read or write to/from an address to which that process isn't allowed
344 in Module E:\PB\GeoControlV2\Libs\Events.pb

Should GeoControl try to continue?

[cajomi]

Bug fixed for next build!
Thank you.